skorotkiewicz/gamja
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Turn dialog close button into a <button>

Browse source 
This is semantically more correct.
This commit is contained in:
Simon Ser 2021-06-22 16:02:55 +02:00
parent 1ea3180f5b
commit 0d36e8a3fc
2 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/dialog.js
View file

@ -50,8 +50,8 @@ export default class Dialog extends Component {
<div class="dialog" onClick=${this.handleBackdropClick}>
<div class="dialog-body" ref=${this.body}>
<div class="dialog-header">
<a href="#" class="dialog-close" onClick=${this.handleCloseClick}>×</span>
<h2>${this.props.title}</h2>
<button class="dialog-close" onClick=${this.handleCloseClick}>×</button>
</div>
${this.props.children}
</div>