skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change hidden score placeholder from ? to empty string

Browse source
This commit is contained in:
Inire 2022-10-28 19:36:50 +11:00 • committed by Ben Rog-Wilhelm
parent 0991dc7ed2
commit 08a98429e0
4 changed files with 20 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

17
files/assets/js/comments+submission_listing.js
View file

@ -153,6 +153,11 @@ function vote(type, id, dir, vid) {
const downvotes = document.getElementsByClassName(type + '-' + id + '-down'); const downvotes = document.getElementsByClassName(type + '-' + id + '-down');
const scoretexts = document.getElementsByClassName(type + '-score-' + id); const scoretexts = document.getElementsByClassName(type + '-score-' + id);
// the score value might not be a number if scores are hidden
function is_int(str) {
return str.match(/-?\d+/) != null
}
for (let i=0; i<upvotes.length; i++) { for (let i=0; i<upvotes.length; i++) {
const upvote = upvotes[i] const upvote = upvotes[i]
@ -163,7 +168,7 @@ function vote(type, id, dir, vid) {
if (dir == "1") { if (dir == "1") {
if (upvote.classList.contains('active')) { if (upvote.classList.contains('active')) {
upvote.classList.remove('active') upvote.classList.remove('active')
if (!isNaN(scoretext.textContent)) { if (is_int(scoretext.textContent)) {
scoretext.textContent = score - 1 scoretext.textContent = score - 1
} }
votedirection = "0" votedirection = "0"
@ -171,13 +176,13 @@ function vote(type, id, dir, vid) {
} else if (downvote.classList.contains('active')) { } else if (downvote.classList.contains('active')) {
upvote.classList.add('active') upvote.classList.add('active')
downvote.classList.remove('active') downvote.classList.remove('active')
if (!isNaN(scoretext.textContent)) { if (is_int(scoretext.textContent)) {
scoretext.textContent = score + 2 scoretext.textContent = score + 2
} }
votedirection = "1" votedirection = "1"
} else { } else {
upvote.classList.add('active') upvote.classList.add('active')
if (!isNaN(scoretext.textContent)) { if (is_int(scoretext.textContent)) {
scoretext.textContent = score + 1 scoretext.textContent = score + 1
} }
votedirection = "1" votedirection = "1"
@ -201,7 +206,7 @@ function vote(type, id, dir, vid) {
else { else {
if (downvote.classList.contains('active')) { if (downvote.classList.contains('active')) {
downvote.classList.remove('active') downvote.classList.remove('active')
if (!isNaN(scoretext.textContent)) { if (is_int(scoretext.textContent)) {
scoretext.textContent = score + 1 scoretext.textContent = score + 1
} }
votedirection = "0" votedirection = "0"
@ -209,13 +214,13 @@ function vote(type, id, dir, vid) {
} else if (upvote.classList.contains('active')) { } else if (upvote.classList.contains('active')) {
downvote.classList.add('active') downvote.classList.add('active')
upvote.classList.remove('active') upvote.classList.remove('active')
if (!isNaN(scoretext.textContent)) { if (is_int(scoretext.textContent)) {
scoretext.textContent = score - 2 scoretext.textContent = score - 2
} }
votedirection = "-1" votedirection = "-1"
} else { } else {
downvote.classList.add('active') downvote.classList.add('active')
if (!isNaN(scoretext.textContent)) { if (is_int(scoretext.textContent)) {
scoretext.textContent = score - 1 scoretext.textContent = score - 1
} }
votedirection = "-1" votedirection = "-1"

6
files/templates/comments.html
View file

@ -48,9 +48,9 @@
{% if c.should_hide_score %} {% if c.should_hide_score %}
{% set ups="?" %} {% set ups="" %}
{% set downs="?" %} {% set downs="" %}
{% set score="?" %} {% set score="" %}
{% else %} {% else %}
{% set ups=c.upvotes %} {% set ups=c.upvotes %}
{% set downs=c.downvotes %} {% set downs=c.downvotes %}

6
files/templates/submission.html
View file

@ -2,9 +2,9 @@
{% if p.should_hide_score %} {% if p.should_hide_score %}
{% set ups="?" %} {% set ups="" %}
{% set downs="?" %} {% set downs="" %}
{% set score="?" %} {% set score="" %}
{% else %} {% else %}
{% set ups=p.upvotes %} {% set ups=p.upvotes %}
{% set downs=p.downvotes %} {% set downs=p.downvotes %}

6
files/templates/submission_listing.html
View file

@ -48,9 +48,9 @@
<div class="card-container"> <div class="card-container">
{% if p.should_hide_score %} {% if p.should_hide_score %}
{% set ups="?" %} {% set ups="" %}
{% set downs="?" %} {% set downs="" %}
{% set score="?" %} {% set score="" %}
{% else %} {% else %}
{% set ups=p.upvotes %} {% set ups=p.upvotes %}
{% set downs=p.downvotes %} {% set downs=p.downvotes %}