skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cleanup sidebar sizing style kludges

Browse source 
The 15-line <pre> block at the bottom of the sidebar was a fix for
mobile hamburger menu behavior on upstream, where the long mobile
sidebar would be covered by the bottom navigation drawer.

In-place replacement would be `margin-bottom: 15em`, but it's not
actually necessary for the sidebar as used on TheMotte, and it adds
an unsightly block of whitespace to the bottom of the homepage.

Also the `style` attribute width was related to `GET /sidebar`
behavior (sidebar.html), which is unused on TheMotte, having been
replaced in the signup template with a link to `/rules`.
This commit is contained in:
TLSM 2023-02-04 03:40:31 -05:00 • committed by Ben Rog-Wilhelm
parent 7a9a3f7c99
commit 175f9c1d22
2 changed files with 4 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

3
files/assets/css/main.css
View file

@ -5031,6 +5031,9 @@ a.emojitab {
padding: 2px 5px; padding: 2px 5px;
font-weight: 700; font-weight: 700;
} }
.sidebar {
max-width: 300px;
}
li > .sidebar { li > .sidebar {
display: block !important; display: block !important;
max-width: 100% !important; max-width: 100% !important;

22
files/templates/sidebar_TheMotte.html
View file

@ -1,13 +1,9 @@
<div class="col sidebar text-left d-none d-lg-block pt-4 pb-5 bg-white" style="max-width:300px"> <div class="col sidebar text-left d-none d-lg-block pt-4 pb-5 bg-white">
<div class="d-none d-lg-block"> <div class="d-none d-lg-block">
{% include "nav_secondary.html" %} {% include "nav_secondary.html" %}
</div> </div>
{% if sub %}
{% set image=sub.sidebar_url %}
{% endif %}
{% if sub %} {% if sub %}
{% if sub.sidebar_html %} {% if sub.sidebar_html %}
<div class="mb-4">{{sub.sidebar_html|safe}}</div> <div class="mb-4">{{sub.sidebar_html|safe}}</div>
@ -134,20 +130,4 @@
</ul> </ul>
</div> </div>
{% endif %} {% endif %}
<pre>
</pre>
</div> </div>