skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix leaderboard 500 on production (NotImplementedError) (#563)

Browse source 
* leaderboard: correct LB set when !ENABLE_SERVICES

* leaderboard: fix NotImplementedError

UserBlockLeaderboard did not, in fact, implement `value_func`. Nor did
its superclass. The bug was replicated by having at least one UserBlock
in the test data.
This commit is contained in:
Snakes 2023-03-29 18:45:28 -04:00 • committed by GitHub
parent 1f7e7afad3
commit 1cf017c42a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
files/classes/leaderboard.py
View file

@ -132,7 +132,7 @@ class BadgeMarseyLeaderboard(_CountedAndRankedLeaderboard):
@property
def value_func(self) -> Callable[[User], int]:
return lambda u:self._all_users[u]
return lambda u: self._all_users[u]
class UserBlockLeaderboard(_CountedAndRankedLeaderboard):
def __init__(self, v:User, meta:LeaderboardMeta, db:Session, column:Column):
@ -168,6 +168,10 @@ class UserBlockLeaderboard(_CountedAndRankedLeaderboard):
def v_value(self) -> int:
return self._v_value
@property
def value_func(self) -> Callable[[User], int]:
return lambda u: self._all_users[u]
class RawSqlLeaderboard(Leaderboard):
def __init__(self, meta:LeaderboardMeta, db:Session, query:str) -> None: # should be LiteralString on py3.11+
super().__init__(None, meta)