skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Eager load get_posts for submission_listings.

Browse source 
Ported in logic from upstream to use SQLAlchemy eager loading instead
of repeated queries when building a submission_listing. Adjusted
loaded relationships to include only those used on TheMotte.

Using test data from seed_db, before and after:

GET /
|----------|--------|--------|--------|--------|--------|------------|
| Database | SELECT | INSERT | UPDATE | DELETE | Totals | Duplicates |
|----------|--------|--------|--------|--------|--------|------------|
| default  |   83   |   0    |   0    |   0    |   83   |     72     |
|----------|--------|--------|--------|--------|--------|------------|
Total queries: 83 in 0.031s

GET /
|----------|--------|--------|--------|--------|--------|------------|
| Database | SELECT | INSERT | UPDATE | DELETE | Totals | Duplicates |
|----------|--------|--------|--------|--------|--------|------------|
| default  |   14   |   0    |   0    |   0    |   14   |     0      |
|----------|--------|--------|--------|--------|--------|------------|
Total queries: 14 in 0.00718s
This commit is contained in:
TLSM 2022-11-28 12:55:31 -05:00
parent 9953c5763c
commit 4d22d9bce2
No known key found for this signature in database
GPG key ID: E745A82778055C7E
5 changed files with 24 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
files/routes/users.py
View file

@ -90,7 +90,7 @@ def upvoters_posts(v, username, uid):
next_exists = len(listing) > 25
listing = listing[:25]
listing = get_posts(listing, v=v)
listing = get_posts(listing, v=v, eager=True)
return render_template("voted_posts.html", next_exists=next_exists, listing=listing, page=page, v=v)
@ -132,7 +132,7 @@ def downvoters_posts(v, username, uid):
next_exists = len(listing) > 25
listing = listing[:25]
listing = get_posts(listing, v=v)
listing = get_posts(listing, v=v, eager=True)
return render_template("voted_posts.html", next_exists=next_exists, listing=listing, page=page, v=v)
@ -173,7 +173,7 @@ def upvoting_posts(v, username, uid):
next_exists = len(listing) > 25
listing = listing[:25]
listing = get_posts(listing, v=v)
listing = get_posts(listing, v=v, eager=True)
return render_template("voted_posts.html", next_exists=next_exists, listing=listing, page=page, v=v)
@ -215,7 +215,7 @@ def downvoting_posts(v, username, uid):
next_exists = len(listing) > 25
listing = listing[:25]
listing = get_posts(listing, v=v)
listing = get_posts(listing, v=v, eager=True)
return render_template("voted_posts.html", next_exists=next_exists, listing=listing, page=page, v=v)
@ -824,7 +824,7 @@ def u_username(username, v=None):
for p in sticky:
ids = [p.id] + ids
listing = get_posts(ids, v=v)
listing = get_posts(ids, v=v, eager=True)
if u.unban_utc:
if request.headers.get("Authorization"): {"data": [x.json for x in listing]}
@ -1105,7 +1105,7 @@ def saved_posts(v, username):
ids=ids[:25]
listing = get_posts(ids, v=v)
listing = get_posts(ids, v=v, eager=True)
if request.headers.get("Authorization"): return {"data": [x.json for x in listing]}
return render_template("userpage.html",