Fix: Mod-only information leaked via the API. (#696)

This commit is contained in:
Ben Rog-Wilhelm 2023-09-04 23:09:54 -05:00 committed by GitHub
parent 41497958b6
commit 75edfe8b31
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 15 deletions

View file

@ -213,9 +213,6 @@ class Comment(CreatedBase):
@property
@lazy
def json_raw(self):
flags = {}
for f in self.flags(None): flags[f.user.username] = f.reason
data= {
'id': self.id,
'level': self.level,
@ -230,13 +227,14 @@ class Comment(CreatedBase):
'is_pinned': self.is_pinned,
'distinguish_level': self.distinguish_level,
'post_id': self.post.id if self.post else 0,
'score': self.score,
'upvotes': self.upvotes,
'downvotes': self.downvotes,
'is_bot': self.is_bot,
'flags': flags,
}
if not self.should_hide_score:
data['score'] = self.score
data['upvotes'] = self.upvotes
data['downvotes'] = self.downvotes
return data
def award_count(self, kind):

View file

@ -222,9 +222,6 @@ class Submission(CreatedBase):
@property
@lazy
def json_raw(self):
flags = {}
for f in self.flags(None): flags[f.user.username] = f.reason
data = {'author_name': self.author_name if self.author else '',
'permalink': self.permalink,
'shortlink': self.shortlink,
@ -241,16 +238,17 @@ class Submission(CreatedBase):
'created_utc': self.created_utc,
'edited_utc': self.edited_utc or 0,
'comment_count': self.comment_count,
'score': self.score,
'upvotes': self.upvotes,
'downvotes': self.downvotes,
'stickied': self.stickied,
'private' : self.private,
'distinguish_level': self.distinguish_level,
'voted': self.voted if hasattr(self, 'voted') else 0,
'flags': flags,
}
if not self.should_hide_score:
data['score'] = self.score
data['upvotes'] = self.upvotes
data['downvotes'] = self.downvotes
return data
@property

View file

@ -519,7 +519,6 @@ class User(CreatedBase):
data = self.json_core
data["badges"] = [x.json for x in self.badges]
data['coins'] = self.coins
data['post_count'] = self.post_count
data['comment_count'] = self.comment_count