From b04849e5b7a74fa3d24c9baf6bf0a0a46c5614f7 Mon Sep 17 00:00:00 2001 From: TLSM Date: Mon, 3 Apr 2023 12:59:43 -0400 Subject: [PATCH] hotfix: comment nesting in template from #535 In some cases, #535 caused comment display to wildly break visible page formatting. The sidebar often moved to bottom of page, and some comments would display in a second column alongside the main one. Root cause was a closing `` left outside of a conditional which was included in rendered markup even when: 1) A comment is invisible for the current browsing user v, e.g. filtered or removed. 2) The subtree rooted at said comment is to be hidden based on the display logic added in #535. Which left a stray `` with no opening tag where those comments should've gone. Most of the testing appears to have been done on reply chains of comments, which behave correctly. It is specifically the zero children (or otherwise not even showing a "Removed" message in the page) which causes the bug. --- files/templates/comments.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/templates/comments.html b/files/templates/comments.html index afeceaaa1..6279858c1 100644 --- a/files/templates/comments.html +++ b/files/templates/comments.html @@ -52,9 +52,9 @@ {% endif %} {% endif %} + {% endif %} - {% else %}