skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: filtered posts on frontpage listing

Browse source 
Desired behavior for new posts when FilterNewPosts setting is enabled
is that people with admin_level >= 2 and post authors should see their
post on the frontpage, while all other unprivileged users shouldn't.

The logic for this is already in `files.helpers.listing` but it was
overridden by a second filter condition which required `state_mod =
VISIBLE`.

`(state_mod = VISIBLE | author_id = v.id) & (state_mod = VISIBLE)`
simplifies in an unfortunate way. The latter condition was also not
conditional on admin_level. Simply removing it fixes the listing
for both post authors and privileged users.
This commit is contained in:
TLSM 2023-07-20 22:26:32 -04:00 • committed by Ben Rog-Wilhelm
parent a2aa7353fc
commit c519a1a292
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
files/helpers/listing.py
View file

@ -45,7 +45,7 @@ def frontlist(v=None, sort='new', page=1, t="all", ids_only=True, ccmode="false"
if (ccmode == "true"): if (ccmode == "true"):
posts = posts.filter(Submission.club == True) posts = posts.filter(Submission.club == True)
posts = posts.filter_by(state_mod=StateMod.VISIBLE, private=False, state_user_deleted_utc=None) posts = posts.filter_by(private=False, state_user_deleted_utc=None)
if ccmode == "false" and not gt and not lt: if ccmode == "false" and not gt and not lt:
posts = posts.filter_by(stickied=None) posts = posts.filter_by(stickied=None)