skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rDrama/files/templates
History
painejohn 0e165e17c0 Fixes #110 "Signout doesn't always work" 
I tried reproducing the issues from #110 but without luck. The
workflow looks a little like this:

- User changes their avatar.
    - This triggers a POST request to the profile endpoint.
- User clicks "Log out" from the dropdown menu"
    - This triggers the post_toast function in js that makes a POST to
      /logout, which clears the user's session. Then, on receipt of the
      response, the js calls `location.reload`, which replays the
      browser's last action, which in our case is the earlier POST
      request to the profile endpoint. This is why the browser asks
      whether it's OK to resubmit the data _again_. Agreeing resubmits
      the first POST request.
    - After `location.reload`, since the user is no longer logged in,
      they either get a 405 (from the profile edit page) or a 500 (from
      the profile overview page).

This PR then changes the `/logout` endpoint from POST to GET, then
updates the header template to change the "Log out" anchor to simply
link to "/logout" instead of calling any js.

Reasoning behind it:
- logout doesn't modify server-side resources, so it's safe to make it a
  GET request.
- Making it a GET prevents the browser from ever displaying the "data
  resubmit" warning window.
- The "/logout" endpoint can now simply redirect to the homepage.
2022-07-29 06:47:19 -05:00
..
admin Support settings for integers and allow setting filter settings in UI 2022-07-09 06:33:41 -05:00
email Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
errors Removed emoji images from error pages 2022-05-18 20:05:12 -05:00
sub Add trailing LF to text files 2022-05-10 21:05:51 -04:00
admins.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
agendaposters.html fsfd 2022-02-24 14:03:28 +02:00
api.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
authforms.html Remove some gimmicky r/drama features. 2022-05-21 21:43:00 -05:00
award_modal.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
badges.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
ban_modal.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
banned.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
blocks.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
changelog.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
chat.html Removed emoji feature from templates and deleted emoji images 2022-05-18 20:53:28 -05:00
comments.html Merge pull request #122 from zorbathut/pr_fixvote 2022-07-26 23:19:33 -04:00
contact.html Made a lot of small changes in the frontend 2022-06-04 07:48:26 -05:00
default.html Fixed 404 on random user button and changed icons 2022-06-05 17:02:34 -05:00
delete_post_modal.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
expanded_image_modal.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
followers.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
following.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
forgot_password.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
formatting.html Replace formatting examples with less, uh, culturally specific examples. 2022-07-23 12:38:47 -05:00
gif_modal.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
grassed.html fsfd 2022-02-24 14:03:28 +02:00
header.html Fixes #110 "Signout doesn't always work" 2022-07-29 06:47:19 -05:00
home.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
home_comments.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
journoid_banner.html Update journoid_banner.html 2022-05-02 15:13:10 -04:00
leaderboard.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
log.html Up-merged and resolved conflicts in routes/login.p and routes/votes.py 2022-05-22 08:23:59 -05:00
login.html Replaced art assets 2022-06-02 18:30:43 -05:00
login_2fa.html Replaced art assets 2022-06-02 18:30:43 -05:00
lost_2fa.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
message.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
message_success.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
mine.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
mobile_navigation_bar.html Made a lot of small changes in the frontend 2022-06-04 07:48:26 -05:00
notifications.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
oauth.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
patrons.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
post_actions.html Hide vote details from non-admins. 2022-07-23 03:04:43 -05:00
post_actions_mobile.html Hide vote details from non-admins. 2022-07-23 03:04:43 -05:00
post_admin_actions_mobile.html Added new default text and default link thumbnails, color fixes for some buttons 2022-06-03 06:36:03 -05:00
report_post_modal.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
reset_password.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
rules.html Update rule text for new site. 2022-05-15 14:21:17 -05:00
search.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
search_comments.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
search_users.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
settings.html Remove some gimmicky r/drama features. 2022-05-21 21:43:00 -05:00
settings2.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
settings_apps.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
settings_blocks.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
settings_css.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
settings_filters.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
settings_profile.html Made a lot of small changes in the frontend 2022-06-04 07:48:26 -05:00
settings_profilecss.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
settings_security.html Made a lot of small changes in the frontend 2022-06-04 07:48:26 -05:00
shadowbanned.html fsfd 2022-02-24 14:03:28 +02:00
shop.html gdfg 2022-03-31 18:28:53 +02:00
sidebar.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
sidebar_TheMotte.html Update rule text for new site. 2022-05-15 14:21:17 -05:00
sign_up.html Change the JS email regex to match our internal one. 2022-07-03 10:13:59 -05:00
sign_up_failed_ref.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
submission.html Fixed reply-twice bug on submission page. 2022-06-29 00:25:11 -05:00
submission_banned.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
submission_listing.html Update annoying magic numbers. 2022-07-24 05:52:31 -05:00
submit.html Added caching to /@username/pic endpoint, other small fixes 2022-06-09 05:36:45 -05:00
transfers.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
user_listing.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
usernote.html Adding usernotes. 2022-05-16 11:53:24 -05:00
userpage.html Fix: Upvoted/Downvoted link visibility was based on the viewee, not the viewer. 2022-07-24 06:01:16 -05:00
userpage_blocked.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
userpage_blocking.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
userpage_comments.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
userpage_private.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
userpage_reserved.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
viewers.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
voted_comments.html vote relationships 2022-03-22 02:01:21 +02:00
voted_posts.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
voters.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
votes.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00