
* prepare codebase to create scheduled tasks
there is some prep work involved with this. the scheduler would be happy
if this work was done. simply, we extract out the `created_utc`
interface from *everything* that uses it such that we don't have to
repeat ourselves a bunch. all fun stuff.
next commit is the meat of it.
* cron: basic backend work for scheduler
* avoid ipmort loop
* attempt 2 at fixing import loops
* parathensize because operator precedence
* delete file that came back for some reason.
* does NOPing the oauth apps work?
* import late and undo clients.py change
* stringify column names.
* reorder imports.
* remove task reference
* fix missing mapper object
* make coupled to repeatabletask i guess
* sanitize: fix sanitize imports
* import shadowing crap
* re-shadow shadowed variable
* fix regexes
* use the correct not operator
* readd missing commit
* scheduler: SQLA only allows concrete relations
* implement submission scheduler
* fix import loop with db_session
* get rid of import loop in submission.py and comment.py
* remove import loops by deferring import until function clal
* i give up.
* awful.
* ...
* fix another app import loop
* fix missing import in route handler
* fix import error in wrappers.py
* fix wrapper error
* call update wrapper in the admin_level_required case
* :marseyshrug:
* fix issue with wrapper
* some cleanup and some fixes
* some more cleanup
let's avoid polluting scopes where we can.
* ...
* add SCHEDULED_POSTS permission.
* move const.py into config like the other files.
* style fixes.
* lock table for concurrency improvements
* don't attempt to commit on errors
* Refactor code, create `TaskRunContext`, create python callable task type.
* use import contextlib
* testing stuff i guess.
* handle repeatable tasks properly.
* Attempt another fix at fighting the mapper
* do it right ig
* SQLA1.4 doesn't support nested polymorphism ig
* fix errenous class import
* fix mapper errors
* import app in wrappers.py
* fix import failures and stuff like that.
* embed and import fixes
* minor formatting changes.
* Add running state enum and don't attempt to check for currently running tasks.
* isort
* documentation, style, and commit after each task.
* Add completion time and more docs, rename, etc
* document `CRON_SLEEP_SECONDS` better.
* add note about making LiteralString
* filter out tasks that have been run in the future
* reference RepeatableTask's `__tablename__` directly
* use a master/slave configuration for tasks
the master periodically checks to see if the slave is alive, healthy,
and not taking too many resources, and if applicable kills its
child and restarts it.
only one relation is supported at the moment.
* don't duplicate process unnecessarily
* note impl detail, add comments
* fix imports.
* getting imports to stop being stupid.
* environment notes.
* syntax derp
* *sigh*
* stupid environment stuff
* add UI for submitting a scheduled post
* stupid things i need to fix the user class
* ...
* fix template
* add formkey
* pass v
* add hour and minute field
* bleh
* remove concrete
* the sqlalchemy docs are wrong
* fix me being dumb and not understanding error messages
* missing author attribute for display
* author_name property
* it's a property
* with_polymorphic i think fixes this
* dsfavgnhmjk
* *sigh*
* okay try this again
* try getting rid of the comment section
* include -> extends
* put the div outside of the thing.
* fix user page listings :/
* mhm
* i hate this why isn't this working
* this should fix it
* Fix posts being set as disabled by default
* form UI imrpovements
* label
* <textarea>s should have their closing tag
* UI fixes.
* and fix errenous spinner thing.
* don't abort(415) when browsers send 0 length files for some reason
* UI improvements
* line break.
* CSS :S
* better explainer
* don't show moderation buttons for scheduled posts
* ...
* meh
* add edit form
* include forms on default page.
* fix hour minute selectino.
* improve ui i guess and add api
* Show previous postings on scheduled task page
* create task id
* sqla
* posts -> submissions
* fix OTM relationship
* edit URL
* use common formkey control
* Idk why this isn't working
* Revert "Idk why this isn't working"
This reverts commit 3b93f741df
.
* does removing viewonly fix it?
* don't import routes on db migrations
* apparently this has to be a string
* UI improvements redux
* margins and stuff
* add cron to supervisord
* remove stupid duplication
* typo fix
* postgres syntax error
* better lock and error handling
* add relationship between task and runs
* fix some ui stuff
* fix incorrect timestamp comparison
* ...
* Fix logic errors blocking scheduled posts
Two bugs here:
- RepeatableTask.run_time_last <= now: run_time_last is NULL by
default. NULL is not greater than, less than, or equal to any
value. We use NULL to signify a never-run task; check for that
condition when building the task list.
- `6 <= weekday <= 0`: there is no integer that is both gte 6 and
lte 0. This was always false.
* pasthrough worker process STDOUT and STDERR
* Add scheduler to admin panel
* scheduler
* fix listing and admin home
* date formatting ixes
* fix ages
* task user interface
* fix some more import crap i have to deal with
* fix typing
* avoid import loop
* UI fixes
* fix incorrect type
* task type
* Scheduled task UI improvements (add runs and stuff)
* make the width a lil bit smaller
* task runs.
* fix submit page
* add alembic migration
* log on startup
* Fix showing edit button
* Fix logic for `can_edit` (accidentally did `author_id` instead of `id`)
* Broad review pass
Review:
- Call `invalidate_cache` with `is_html=` explicitly for clarity,
rather than a bare boolean in the call args.
- Remove `marseys_const*` and associated stateful const system:
the implementation was good if we needed them, but TheMotte
doesn't use emoji, and a greenfield emoji system would likely
not keep those darned lists floating in thread-local scope.
Also they were only needed for goldens and random emoji, which
are fairly non-central features.
- Get `os.environ` fully out of the templates by using the new
constants we already have in files.helpers.config.environment.
- Given files.routes.posts cleanup,get rid of shop discount dict.
It's already a mapping of badge IDs to discounts for badges that
likely won't continue to exist (if they even do at present).
- RepeatableTaskRun.exception: use `@property.setter` instead of
overriding `__setattr__`.
Fix:
- Welcome message literal contained an indented Markdown code block.
- Condition to show "View source" button changed to show source to
logged out. This may well be a desirable change, but it's not
clearly intended here.
* Fix couple of routing issues
* fix 400 with post body editing
* Add error handler for HTTP 415
* fix router giving wrong arg name to handler
* Use supervisord to monitor memory rather than DIY
Also means we're using pip for getting supervisord now, so we don't rely
on the Debian image base for any packages.
* fix task run elapsed time display
* formatting and removing redundant code
* Fix missing ModAction import
* dates and times fixes
* Having to modify imports here anyway, might as
well change it.
* correct documentation.
* don't use urlunparse
* validators: import sanitize instead of from syntax
* cron: prevent races on task running
RepeatableTask.run_state_enum acts as the mutex on repeatable tasks.
Previously, the list of tasks to run was acquired before individually
locking each task. However, there was a period where the table is both
unlocked and the tasks are in state WAITING between those points.
This could potentially have led to two 'cron' processes each running the
same task simultaneously. Instead, we check for runnability both when
building the preliminary list and when mutexing the task via run state
in the database.
Also:
- g.db and the cron db object are both instances of `Session`, not
`scoped_session` because they are obtained from
`scoped_session.__call__`, which acts as a `Session` factory.
Propagate this to the type hints.
- Sort order of task run submissions so /tasks/scheduled_posts/<id>
"Previous Task Runs" listings are useful.
* Notify followers on post publication
This was old behavior lost in the refactoring of the submit endpoint.
Also fix an AttributeError in `Follow.__repr__` which carried over
from all the repr copypasta.
* Fix image attachment
Any check for `file.content_length` relies on browsers sending
Content-Length headers with the request. It seems that few actually do.
The pre-refactor approach was to check for truthiness, which excludes
both None and the strange empty strings that we seem to get in absence
of a file upload. We return to doing so.
---------
Co-authored-by: TLSM <duolsm@outlook.com>
252 lines
8 KiB
Python
252 lines
8 KiB
Python
from dataclasses import dataclass
|
|
from typing import Any, Callable, Final, Optional
|
|
|
|
from sqlalchemy import Column, func
|
|
from sqlalchemy.orm import Session, Query
|
|
|
|
from files.helpers.config.const import LEADERBOARD_LIMIT
|
|
|
|
from files.classes.badges import Badge
|
|
from files.classes.marsey import Marsey
|
|
from files.classes.user import User
|
|
from files.classes.userblock import UserBlock
|
|
from files.helpers.get import get_accounts_dict
|
|
|
|
@dataclass(frozen=True, slots=True)
|
|
class LeaderboardMeta:
|
|
header_name:str
|
|
table_header_name:str
|
|
html_id:str
|
|
table_column_name:str
|
|
user_relative_url:Optional[str]
|
|
limit:int=LEADERBOARD_LIMIT
|
|
|
|
class Leaderboard:
|
|
def __init__(self, v:Optional[User], meta:LeaderboardMeta) -> None:
|
|
self.v:Optional[User] = v
|
|
self.meta:LeaderboardMeta = meta
|
|
|
|
@property
|
|
def all_users(self) -> list[User]:
|
|
raise NotImplementedError()
|
|
|
|
@property
|
|
def v_position(self) -> Optional[int]:
|
|
raise NotImplementedError()
|
|
|
|
@property
|
|
def v_value(self) -> Optional[int]:
|
|
raise NotImplementedError()
|
|
|
|
@property
|
|
def v_appears_in_ranking(self) -> bool:
|
|
return self.v_position is not None and self.v_position <= len(self.all_users)
|
|
|
|
@property
|
|
def user_func(self) -> Callable[[Any], User]:
|
|
return lambda u:u
|
|
|
|
@property
|
|
def value_func(self) -> Callable[[User], int]:
|
|
raise NotImplementedError()
|
|
|
|
class SimpleLeaderboard(Leaderboard):
|
|
def __init__(self, v:User, meta:LeaderboardMeta, db:Session, users_query:Query, column:Column):
|
|
super().__init__(v, meta)
|
|
self.db:Session = db
|
|
self.users_query:Query = users_query
|
|
self.column:Column = column
|
|
self._calculate()
|
|
|
|
def _calculate(self) -> None:
|
|
self._all_users = self.users_query.order_by(self.column.desc()).limit(self.meta.limit).all()
|
|
if self.v not in self._all_users:
|
|
sq = self.db.query(User.id, self.column, func.rank().over(order_by=self.column.desc()).label("rank")).subquery()
|
|
sq_data = self.db.query(sq.c.id, sq.c[self.column.name], sq.c.rank).filter(sq.c.id == self.v.id).limit(1).one()
|
|
self._v_value:int = sq_data[1]
|
|
self._v_position:int = sq_data[2]
|
|
|
|
@property
|
|
def all_users(self) -> list[User]:
|
|
return self._all_users
|
|
|
|
@property
|
|
def v_position(self) -> int:
|
|
return self._v_position
|
|
|
|
@property
|
|
def v_value(self) -> int:
|
|
return self._v_value
|
|
|
|
@property
|
|
def value_func(self) -> Callable[[User], int]:
|
|
return lambda u:getattr(u, self.column.name)
|
|
|
|
class _CountedAndRankedLeaderboard(Leaderboard):
|
|
@classmethod
|
|
def count_and_label(cls, criteria):
|
|
return func.count(criteria).label("count")
|
|
|
|
@classmethod
|
|
def rank_filtered_rank_label_by_desc(cls, criteria):
|
|
return func.rank().over(order_by=func.count(criteria).desc()).label("rank")
|
|
|
|
class BadgeMarseyLeaderboard(_CountedAndRankedLeaderboard):
|
|
def __init__(self, v:User, meta:LeaderboardMeta, db:Session, column:Column):
|
|
super().__init__(v, meta)
|
|
self.db:Session = db
|
|
self.column = column
|
|
self._calculate()
|
|
|
|
def _calculate(self):
|
|
sq = self.db.query(self.column, self.count_and_label(self.column), self.rank_filtered_rank_label_by_desc(self.column)).group_by(self.column).subquery()
|
|
sq_criteria = None
|
|
if self.column == Badge.user_id:
|
|
sq_criteria = User.id == sq.c.user_id
|
|
elif self.column == Marsey.author_id:
|
|
sq_criteria = User.id == sq.c.author_id
|
|
else:
|
|
raise ValueError("This leaderboard function only supports Badge.user_id and Marsey.author_id")
|
|
leaderboard = self.db.query(User, sq.c.count).join(sq, sq_criteria).order_by(sq.c.count.desc())
|
|
|
|
position:Optional[tuple[int, int, int]] = self.db.query(User.id, sq.c.rank, sq.c.count).join(sq, sq_criteria).filter(User.id == self.v.id).one_or_none()
|
|
if position and position[1]:
|
|
self._v_position = position[1]
|
|
self._v_value = position[2]
|
|
else:
|
|
self._v_position = leaderboard.count() + 1
|
|
self._v_value = 0
|
|
self._all_users = {k:v for k, v in leaderboard.limit(self.meta.limit).all()}
|
|
|
|
@property
|
|
def all_users(self) -> list[User]:
|
|
return list(self._all_users.keys())
|
|
|
|
@property
|
|
def v_position(self) -> int:
|
|
return self._v_position
|
|
|
|
@property
|
|
def v_value(self) -> int:
|
|
return self._v_value
|
|
|
|
@property
|
|
def value_func(self) -> Callable[[User], int]:
|
|
return lambda u:self._all_users[u]
|
|
|
|
class UserBlockLeaderboard(_CountedAndRankedLeaderboard):
|
|
def __init__(self, v:User, meta:LeaderboardMeta, db:Session, column:Column):
|
|
super().__init__(v, meta)
|
|
self.db:Session = db
|
|
self.column = column
|
|
self._calculate()
|
|
|
|
def _calculate(self):
|
|
if self.column != UserBlock.target_id:
|
|
raise ValueError("This leaderboard function only supports UserBlock.target_id")
|
|
sq = self.db.query(self.column, self.count_and_label(self.column)).group_by(self.column).subquery()
|
|
leaderboard = self.db.query(User, sq.c.count).join(User, User.id == sq.c.target_id).order_by(sq.c.count.desc())
|
|
|
|
sq = self.db.query(self.column, self.count_and_label(self.column), self.rank_filtered_rank_label_by_desc(self.column)).group_by(self.column).subquery()
|
|
position = self.db.query(sq.c.rank, sq.c.count).join(User, User.id == sq.c.target_id).filter(sq.c.target_id == self.v.id).limit(1).one_or_none()
|
|
if not position: position = (leaderboard.count() + 1, 0)
|
|
leaderboard = leaderboard.limit(self.meta.limit).all()
|
|
self._all_users = {k:v for k, v in leaderboard}
|
|
self._v_position = position[0]
|
|
self._v_value = position[1]
|
|
return (leaderboard, position[0], position[1])
|
|
|
|
@property
|
|
def all_users(self) -> list[User]:
|
|
return list(self._all_users.keys())
|
|
|
|
@property
|
|
def v_position(self) -> int:
|
|
return self._v_position
|
|
|
|
@property
|
|
def v_value(self) -> int:
|
|
return self._v_value
|
|
|
|
class RawSqlLeaderboard(Leaderboard):
|
|
def __init__(self, meta:LeaderboardMeta, db:Session, query:str) -> None: # should be LiteralString on py3.11+
|
|
super().__init__(None, meta)
|
|
self.db = db
|
|
self._calculate(query)
|
|
|
|
def _calculate(self, query:str):
|
|
self.result = {result[0]:list(result) for result in self.db.execute(query).all()}
|
|
users = get_accounts_dict(self.result.keys(), db=self.db)
|
|
if users is None:
|
|
raise Exception("Some users don't exist when they should (was a user deleted?)")
|
|
for user in users: # I know.
|
|
self.result[user].append(users[user])
|
|
|
|
@property
|
|
def all_users(self) -> list[User]:
|
|
return [result[2] for result in self.result.values()]
|
|
|
|
@property
|
|
def v_position(self) -> Optional[int]:
|
|
return None
|
|
|
|
@property
|
|
def v_value(self) -> Optional[int]:
|
|
return None
|
|
|
|
@property
|
|
def v_appears_in_ranking(self) -> bool:
|
|
return True # we set this to True here to try and not grab the data
|
|
|
|
@property
|
|
def user_func(self) -> Callable[[Any], User]:
|
|
return lambda u:u
|
|
|
|
@property
|
|
def value_func(self) -> Callable[[User], int]:
|
|
return lambda u:self.result[u.id][1]
|
|
|
|
class ReceivedDownvotesLeaderboard(RawSqlLeaderboard):
|
|
_query: Final[str] = """
|
|
WITH cv_for_user AS (
|
|
SELECT
|
|
comments.author_id AS target_id,
|
|
COUNT(*)
|
|
FROM commentvotes cv
|
|
JOIN comments ON comments.id = cv.comment_id
|
|
WHERE vote_type = -1
|
|
GROUP BY comments.author_id
|
|
), sv_for_user AS (
|
|
SELECT
|
|
submissions.author_id AS target_id,
|
|
COUNT(*)
|
|
FROM votes sv
|
|
JOIN submissions ON submissions.id = sv.submission_id
|
|
WHERE vote_type = -1
|
|
GROUP BY submissions.author_id
|
|
)
|
|
SELECT
|
|
COALESCE(cvfu.target_id, svfu.target_id) AS target_id,
|
|
(COALESCE(cvfu.count, 0) + COALESCE(svfu.count, 0)) AS count
|
|
FROM cv_for_user cvfu
|
|
FULL OUTER JOIN sv_for_user svfu
|
|
ON cvfu.target_id = svfu.target_id
|
|
ORDER BY count DESC LIMIT 25
|
|
"""
|
|
|
|
def __init__(self, meta:LeaderboardMeta, db:Session) -> None:
|
|
super().__init__(meta, db, self._query)
|
|
|
|
class GivenUpvotesLeaderboard(RawSqlLeaderboard):
|
|
_query: Final[str] = """
|
|
SELECT
|
|
COALESCE(cvbu.user_id, svbu.user_id) AS user_id,
|
|
(COALESCE(cvbu.count, 0) + COALESCE(svbu.count, 0)) AS count
|
|
FROM (SELECT user_id, COUNT(*) FROM votes WHERE vote_type = 1 GROUP BY user_id) AS svbu
|
|
FULL OUTER JOIN (SELECT user_id, COUNT(*) FROM commentvotes WHERE vote_type = 1 GROUP BY user_id) AS cvbu
|
|
ON cvbu.user_id = svbu.user_id
|
|
ORDER BY count DESC LIMIT 25
|
|
"""
|
|
|
|
def __init__(self, meta:LeaderboardMeta, db:Session) -> None:
|
|
super().__init__(meta, db, self._query)
|