skorotkiewicz/rDrama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rDrama/files/templates
History
TLSM b04849e5b7 hotfix: comment nesting in template from #535 
In some cases, #535 caused comment display to wildly break visible
page formatting. The sidebar often moved to bottom of page, and some
comments would display in a second column alongside the main one.

Root cause was a closing `</div>` left outside of a conditional
which was included in rendered markup even when:
 1) A comment is invisible for the current browsing user v, e.g.
    filtered or removed.
 2) The subtree rooted at said comment is to be hidden based on
    the display logic added in #535.
Which left a stray `</div>` with no opening tag where those
comments should've gone.

Most of the testing appears to have been done on reply chains of
comments, which behave correctly. It is specifically the zero
children (or otherwise not even showing a "Removed" message in the
page) which causes the bug.
2023-04-03 20:22:41 -06:00
..
admin post scheduling (#554) 2023-03-29 16:32:48 -05:00
component remove holes (#492) 2023-04-01 00:13:30 -05:00
email Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
errors Rework error system a bit to remove a bunch of duplicated code (#434) 2022-12-01 20:58:27 -06:00
util post scheduling (#554) 2023-03-29 16:32:48 -05:00
admins.html remove "meme admin" functionality 2022-11-07 03:33:56 -06:00
agendaposters.html fsfd 2022-02-24 14:03:28 +02:00
analytics.html Try copypasting the Google tag again 2022-10-19 05:43:13 -05:00
api.html Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
authforms.html privatize user CSS (fixes #273) 2023-02-25 04:51:06 -06:00
badges.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
banned.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
blocks.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
changelog.html explicit context passing 2023-02-16 23:50:48 -06:00
chat.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
comments.html hotfix: comment nesting in template from #535 2023-04-03 20:22:41 -06:00
contact.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
csp.html Update CSP to allow Google Analytics. 2022-10-19 06:29:02 -05:00
default.html remove holes (#492) 2023-04-01 00:13:30 -05:00
followers.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
following.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
forgot_password.html Fix: Email regex pattern is inconsistent. 2022-11-13 14:37:18 -06:00
formatting.html components: move around a bit 2023-03-12 07:38:27 -05:00
header.html remove holes (#492) 2023-04-01 00:13:30 -05:00
home.html remove holes (#492) 2023-04-01 00:13:30 -05:00
home_comments.html explicit context passing 2023-02-16 23:50:48 -06:00
journoid_banner.html Update journoid_banner.html 2022-05-02 15:13:10 -04:00
leaderboard.html leaderboard refactor (#526) 2023-02-24 06:31:17 -06:00
log.html privatize user CSS (fixes #273) 2023-02-25 04:51:06 -06:00
login.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
login_2fa.html Update CSP to allow Google Analytics. 2022-10-19 06:29:02 -05:00
lost_2fa.html Fix: Email regex pattern is inconsistent. 2022-11-13 14:37:18 -06:00
message.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
message_success.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
mine.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
mobile_navigation_bar.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
nav_secondary.html Add secondary navbar for orphaned pages. 2022-09-06 12:40:20 -05:00
notifications.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
oauth.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
patrons.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
report_reasons.html Refactor reasons into a shared template 2022-09-26 03:07:48 -05:00
reset_password.html Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
rules.html Add the Support page. 2022-09-19 06:43:42 -05:00
search.html fix indentation and logic error 2023-02-17 00:40:17 -06:00
search_comments.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
search_users.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
settings.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings2.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_apps.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_blocks.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_css.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_filters.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_profile.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_profilecss.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
settings_security.html post scheduling (#554) 2023-03-29 16:32:48 -05:00
shadowbanned.html fsfd 2022-02-24 14:03:28 +02:00
shop.html Replace nearly all ?v= cachebusts with assetcache. 2022-08-30 17:02:46 -04:00
sidebar.html Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
sidebar_TheMotte.html remove holes (#492) 2023-04-01 00:13:30 -05:00
sign_up.html Update CSP to allow Google Analytics. 2022-10-19 06:29:02 -05:00
sign_up_failed_ref.html Update CSP to allow Google Analytics. 2022-10-19 06:29:02 -05:00
submission.html remove holes (#492) 2023-04-01 00:13:30 -05:00
submission_banned.html awards: remove vestiges of awards that don't exist anymore 2023-02-08 18:22:32 -06:00
submission_listing.html remove ruqqus vestige 2023-04-03 03:30:57 -06:00
submit.html remove holes (#492) 2023-04-01 00:13:30 -05:00
support.html Add the Support page. 2022-09-19 06:43:42 -05:00
transfers.html Replaced pseudo-input field on frontpage with a button for creating a post 2022-06-05 16:44:56 -05:00
user_in_table.html leaderboard refactor (#526) 2023-02-24 06:31:17 -06:00
user_listing.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
usernote.html Adding usernotes. 2022-05-16 11:53:24 -05:00
userpage.html remove holes (#492) 2023-04-01 00:13:30 -05:00
userpage_blocking.html Convert text file line endings to LF. 2022-05-09 07:20:47 -05:00
userpage_comments.html explicit context passing 2023-02-16 23:50:48 -06:00
userpage_private.html remove profile songs (ref #470) (#499) 2023-02-10 13:56:04 -06:00
userpage_reserved.html Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
viewers.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
volunteer.html Volunteer Janitor: Minor cleanups. 2022-12-01 18:53:24 -08:00
volunteer_janitor.html fix bug and move render context partly to model 2023-03-09 07:22:01 -06:00
volunteer_submit.html Volunteer Janitor: Minor cleanups. 2022-12-01 18:53:24 -08:00
volunteer_teaser.html Volunteer Janitor: Minor phrasing tweak. 2022-12-01 18:53:24 -08:00
voted_comments.html vote relationships 2022-03-22 02:01:21 +02:00
voted_posts.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
voters.html Add trailing LF to text files 2022-05-10 21:05:51 -04:00
votes.html Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00