rDrama/files
painejohn cbcc2aac6f
139: Disabled multimedia embedding
This change disables multimedia embedding:

- In comments and comments replies.
- In new submissions.
- In comment & submission preview

And it's all toggle-able via an envvar, except for the JS bits,
but I linked those to the github issue, so should be easy to find
in the future.

The way it works is:

- removes markdown image/video syntax,
  eg. `![](https://example.org/someimage.jpg)` into ``
- changes link text into anchors, eg.
  `https://example.org/someimage.jpg` into
  `[https://example.org/someimage.jpg](https://example.org/someimage.jpg)`
- removes html img/video/audio tags, eg.
  `<img href="https://example.org/someimage.jpg" />` into ``
- when embedding gifs via the giphy modal in "new submission", it will
  insert only an anchor to the gif
- when attaching an image, it will upload the image, then add only an
  anchor to the post/comment body

I tested this manually, but not sure if I got all the test cases. What I
checked was:

- create comment w/ image/video/audio media using markdown -> success
- create comment reply w/ image/video/audio media using markdown ->
  success
- create comment w/ link to img/imgur/youtube/audio -> success
- create comment w/ attachment -> success
- create comment reply w/ attachment -> success
- create comment w/ img/video tag -> success
- create comment reply w/ image/video tag -> success
- create post submission w/ image/video/media using markdown -> success
- create post submission w/ link to img/imgur/youtube/audio -> success
- create post submission w/ attachment -> success
- create post submission w/ giphy gif -> success

Also, updated the formatting page.

Co-authored-by: Ben Rog-Wilhelm <zorba-github@pavlovian.net>
2022-08-07 01:30:47 -05:00
..
assets 139: Disabled multimedia embedding 2022-08-07 01:30:47 -05:00
classes Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
commands [#72] Add seed_db command 2022-06-09 01:33:58 -07:00
helpers 139: Disabled multimedia embedding 2022-08-07 01:30:47 -05:00
mail Split SITE_NAME into computer-readable SITE_ID and human-readable SITE_TITLE. 2022-07-31 18:53:18 -05:00
routes 139: Disabled multimedia embedding 2022-08-07 01:30:47 -05:00
templates 139: Disabled multimedia embedding 2022-08-07 01:30:47 -05:00
tests Add basic posting to the e2e test. 2022-05-21 21:39:54 -05:00
__init__.py Initial e2e testing 2022-05-13 02:55:29 -05:00
__main__.py 139: Disabled multimedia embedding 2022-08-07 01:30:47 -05:00
cli.py [#72] Ensure seed_db command is actually imported when calling into flask 2022-06-09 01:34:46 -07:00